Fix animation name replacement logic for scene resource reimporting #102226
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… "/" prefix scheme from "get_animation_list"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes upon invoking "Reimport" on certain external scene resources whose original formats support animations ( and likely specifically after the scene has already been instantiated as a child under another scene's root node ), the following error log message may appear:
Such an occurrence is due to how the
AnimationMixer::get_animation_listmethod is implemented to return registered animation names with a prefix of the name of the owning animation library if it is not the default library which is nameless ( https://github.com/PierceLBrooks/godot/blob/plb/import-scene-res-anim-name-replacement-bug/scene/animation/animation_mixer.cpp#L146 ).My changes will resolve this issue.