Fix some global-space bugs in RemoteTransform3D._update_remote and add some optimizations
#102223
+22
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MajorMcDoom
changed the title
RemoteTransform3D._update_remote and optimized a bitRemoteTransform3D._update_remote and add some optimizations
…d optimized a bit
MajorMcDoom
force-pushed
the
remote-transform-fix
branch
from
b6081ce to
5882db3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97470
Supersedes #97498
RemoteTransform3Dhad various inconsistencies when operating in global space, and was also doing more work than necessary for certain combinations of position, rotation and scale updates. This PR fixes that in one go.You can find a little test project here: remote-transform-fix-test.zip
Drag around the
flower_mover(yellow hologram) to move the remote flower.The purple box is the parent of the remote flower, and as you can see, it is rotated and skewed, just to make the test case a bit more interesting. Try various combinations of the four different boolean properties (global space, update position, update rotation, update scale).