Ensure albedo texture size is available for Label3D and Sprite3D #102208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Jan 30, 2025
AThousandShips
approved these changes
Jan 30, 2025
Calinou
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Tested locally on the 3D Labels and Texts and 3D Anti-Aliasing demos, it works as expected in all rendering methods. However, #98173 is not resolved by this PR (since it's a missing feature).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #102180
Regression from: #100280
Neither Label3D nor Sprite3D were setting the "albedo_texture_size" uniform. So when we started using the uniform instead of calculating the size in the shader it broke MSDF.
As a nice side effect, this PR also fixes alpha hash edge antialiasing for Sprite3D and Label3D!