Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add editor setting for FPS mode and compat #102189

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jan 30, 2025

As requested in #98414 (comment)
Although includes some more modifications. I implemented clear() method for animation track editor (previously it would reset state in set_state(), which was wrong). The state of "FPS compat" button is now stored in scene state. The 2 newly added editor settings will determine the default state of the FPS mode and compat buttons when the option is not yet remembered for a scene.

@KoBeWi KoBeWi added this to the 4.x milestone Jan 30, 2025
@KoBeWi KoBeWi requested a review from TokageItLab January 30, 2025 13:04
@KoBeWi KoBeWi requested a review from a team as a code owner January 30, 2025 13:04
@TokageItLab TokageItLab modified the milestones: 4.x, 4.5 Jan 30, 2025
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Approved, Waiting for Production
Development

Successfully merging this pull request may close these issues.

None yet

3 participants