Refactor Debugger, enforce correspondence between name and value #102187
+74
−112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading this part of code, I notice that debugger variable getters do not check if name is correctly mapped to values, but comsumers assume this condition is true(or check explicitly). So I merge
names
andvalues
to amend this hole and place a check in the producers incase there is a mismatch, we can catch it earlier.Since I was already working on this part, I went ahead and did some additional refactoring, mainly
List
and raw pointer stuff. I think they are harmless. If they do cause some problem please tell me.