Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Debugger, enforce correspondence between name and value #102187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YYF233333
Copy link
Contributor

While reading this part of code, I notice that debugger variable getters do not check if name is correctly mapped to values, but comsumers assume this condition is true(or check explicitly). So I merge names and values to amend this hole and place a check in the producers incase there is a mismatch, we can catch it earlier.

Since I was already working on this part, I went ahead and did some additional refactoring, mainly List and raw pointer stuff. I think they are harmless. If they do cause some problem please tell me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants