Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Enum names, improve enum member names, and add related suggestion #10780

Merged
merged 1 commit into from
Apr 11, 2025
Merged

Update Enum names, improve enum member names, and add related suggestion #10780

merged 1 commit into from
Apr 11, 2025

Conversation

Lexyth
Copy link
Contributor

@Lexyth Lexyth commented Mar 18, 2025

  • Changed the grammatical number of all enum names to be singular.
  • Removed the enum names from their members, (e.g.: Tile.TILE_BRICK -> Tile.BRICK).
  • Added a suggestion for the reader to use singular case for enum names.

@Lexyth
Update Enum names, improve enum member names, and add related suggestion
49b3281 
- Changed the grammatical number of all enum names to be singular.
- Removed the enum names from their members, (e.g.: Tile.TILE_BRICK -> Tile.BRICK).
- Added a suggestion for the reader to use singular case for enum names.
@AThousandShips AThousandShips requested a review from a team March 19, 2025 17:04
@dalexeev dalexeev added the area:manual Issues and PRs related to the Manual/Tutorials section of the documentation label Mar 20, 2025
@Lexyth
Copy link
Contributor Author

Lexyth commented Apr 9, 2025

I'm a bit lost.
I don't think this error was caused by anything in my PR specifically, so I've just been waiting for someone to approve/reject it. But now it's been a while and my other PRs from the same day have been merged already, so it feels like that error is blocking the process here.
If someone could tell me whether I have to do something, it'd be appreciated.

dalexeev
dalexeev approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member

@dalexeev dalexeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please try to rebase the branch to fix the failed test.

@skyace65 skyace65 merged commit 8c18714 into godotengine:master Apr 11, 2025
1 of 2 checks passed
@skyace65
Copy link
Contributor

Thanks! Don't worry about that build issue, it was the URL checker, you didn't cause the problem and we don't run it on every PR now.

@Lexyth
Copy link
Contributor Author

Lexyth commented Apr 13, 2025

Oh, good.
I was pretty sure I didn't cause it, since I didn't touch anything URL related, nor change anything escape-codey or similar, but you never know.
I think I tried rerunning the action and got the same result, but maybe I just misremember that. Will try to rebase if it happens again on another PR.

@Lexyth Lexyth deleted the patch-2 branch April 13, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyace65 skyace65 skyace65 approved these changes

@dalexeev dalexeev dalexeev approved these changes

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation discussion enhancement topic:gdscript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lexyth @skyace65 @dalexeev @AThousandShips