Update android_library.rst #10758
Open
Update android_library.rst #10758
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an example for using getCommandLine(). Showing the format for loading pck file in android.
dsnopek
reviewed
Mar 11, 2025
add mising k Co-authored-by: David Snopek <[email protected]>
skyace65
added
enhancement
area:manual
m4gr3d
requested changes
Apr 2, 2025
| @@ -179,6 +179,8 @@ Below we break-down the steps used to create the GLTF Viewer app. | |||
| to the Android app's ``assets`` directory. | |||
| Using this approach requires passing the ``--main-pack <pck_or_zip_filepath_relative_to_assets_dir>`` argument to the hosted Godot Engine instance using `GodotHost#getCommandLine() <https://github.com/godotengine/godot/blob/6916349697a4339216469e9bf5899b983d78db07/platform/android/java/lib/src/org/godotengine/godot/GodotHost.java#L45>`_. | |||
|
|
|||
| Example:``return List.of("--main-pack","ref://foo.pck");`` | |||
There was a problem hiding this comment.
Can you expand the example to show the entire method.
There was a problem hiding this comment.
Also the returned list should include the results from the parent class.
There was a problem hiding this comment.
I just change the example as a entire method
m4gr3d
reviewed
Apr 7, 2025
|
|
||
| @Override | ||
| public List<String> getCommandLine(){ | ||
| return List.of("--main-pack","res://foo.pck"); |
There was a problem hiding this comment.
@WSQS can you include the results from the parent in the returned list.
For example:
List<String> results = new ArrayList<>();
results.addAll(super.getCommandLine());
results.add("--main-pack");
results.add("res://foo.pck");
return results;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an example for using getCommandLine().
Showing the format for loading pck file in android.