Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HashCachedContextLifter: Introduce the lifter and the option #1690

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

arkocal
Copy link
Contributor

@arkocal arkocal commented Feb 19, 2025

Using hashcache on contexes makes a big difference in memory usage (churn) and a reasonable improvement on runtime when HashConsing is disabled. This is particularly important for the upcoming parallel solvers

Using hashcache on contexes makes a big difference in memory usage (churn) and a reasonable improvement on runtime when HashConsing is disabled. This is particularly important for the upcoming parallel solvers
@michael-schwarz michael-schwarz self-requested a review February 19, 2025 09:55
* correct comment on the function of relift
* Rename M->Base for consistency
* Fix relift
Copy link
Member

@sim642 sim642 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With hashconsing there are separate functors for applying it do D and C. This only applies to C.
Is there a reason that hashcaching C is particularly necessary while on D it doesn't really matter?

@sim642 sim642 added this to the v2.6.0 milestone Feb 19, 2025
@sim642 sim642 added the performance Analysis time, memory usage label Feb 19, 2025
@arkocal
Copy link
Contributor Author

arkocal commented Feb 20, 2025

With hashconsing there are separate functors for applying it do D and C. This only applies to C. Is there a reason that hashcaching C is particularly necessary while on D it doesn't really matter?

After analyzing with memtrace, I have found about 90% of memory usage that we can cut down with this comas from C. It can be used on D as well, but it is not as critical.

@sim642 sim642 merged commit 4031cb2 into goblint:master Feb 20, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature performance Analysis time, memory usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants