Audit usages of fold_right
#1688
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-schwarz
commented
Feb 18, 2025
sim642
reviewed
Feb 18, 2025
| | None -> None | ||
| | Some st -> | ||
| let reachable acc e = | ||
| Option.bind acc (fun st -> |
There was a problem hiding this comment.
This could even use let-punning after let open GobOption.Syntax in or something.
There was a problem hiding this comment.
I played around with it, but was unconvinced whether it is easier / more beautiful:
let reachable acc e =
let open GobOption.Syntax in
let* st = acc in
let ad = ask.f (Queries.ReachableFrom e) in
if Queries.AD.is_top ad then
None
else
Some (Queries.AD.join ad st)
inThere was a problem hiding this comment.
@jerhard @DrMichaelPetter @karoliineh @vesalvojdani Opinions on monadic syntax or not?
There was a problem hiding this comment.
Me as a contributor more on the novice side would rather see the explicit binding version instead of the let-punning - call me a simpleton, but I like it better the explicit way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces usages of
fold_rightwith usages offold_leftwherever there is obviously no difference between both. This also raised an instances where I am unsure if the code in Goblint is correct.