Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support slog.Group function #63

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

romanchechyotkin
Copy link

Added support for slog.Group

Since it has pairs to check, i decided to add func log/slog.Group to list of slog functions to make it checkable)

@romanchechyotkin
Copy link
Author

@tmzane i will be pleased to get any feedback

@tmzane
Copy link
Member

tmzane commented Feb 4, 2025

Thanks for the PR!

I'm not sure it's safe to just add slog.Group to the list: it doesn't have the alternative function with the context (so it should not be checked for context-only), it doesn't have the message argument (so it should not be checked for static-msg), probably something else. I'll do some research and update your PR.

@tmzane tmzane changed the title 50 group feat: support slog.Group function Feb 4, 2025
@romanchechyotkin
Copy link
Author

let me know any updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants