Added support for validating OCI tags #1372
Open
+81
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! |
|
I've updated my branch with latest changes from upstream and added to the README.md and doc.go file. |
zemzale
reviewed
Mar 26, 2025
| @@ -211,6 +215,7 @@ validate := validator.New(validator.WithRequiredStructEnabled()) | |||
| | uuid_rfc4122 | Universally Unique Identifier UUID RFC4122 | | |||
| | md4 | MD4 hash | | |||
| | md5 | MD5 hash | | |||
| | oci_tag | Open Container Initiative (OCI) Tag | | |||
There was a problem hiding this comment.
Can we maybe leave this and remove all the other formatting changes?
Otherwise, it doesn't feel clear and should probably be cleaned up in a different PR. There are small things like some lost/changed formatting here and there that I would rather not make part of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Added a new
oci_tagto validate an OCI manifest tag as described in the OCI Distribution Spec: https://github.com/opencontainers/distribution-spec/blob/main/spec.md?plain=1#L164-L166This is also more commonly referred to as a container tag or a docker tag.
Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers