Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(engine): Increase Test Coverage for engine #66

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

notJoon
Copy link
Member

@notJoon notJoon commented Sep 13, 2024

Description

  • Increase engine's test coverage
  • Add some benchmarks
  • refactor filterUndefinedIssues function, increase performace

BenchmarkFilterUndefinedIssues_Prev-8 4466745 252.4 ns/op 1344 B/op 3 allocs/op
BenchmarkFilterUndefinedIssues_New-8 10111783 125.5 ns/op 768 B/op 1 allocs/op
PASS

@notJoon notJoon added enhancement New feature or request performance engine Related with main engine labels Sep 13, 2024
@notJoon notJoon self-assigned this Sep 13, 2024
@notJoon notJoon merged commit c07140d into main Sep 13, 2024
3 checks passed
@notJoon notJoon deleted the increase-test-coverage branch September 13, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine Related with main engine enhancement New feature or request performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant