-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): Implement commit-reveal mechanism for Shifumi game to enhance fairness #2760
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2760 +/- ##
==========================================
- Coverage 60.44% 60.43% -0.01%
==========================================
Files 563 563
Lines 75159 75159
==========================================
- Hits 45427 45423 -4
- Misses 26343 26346 +3
- Partials 3389 3390 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@linhpn99 Thanks! How does a user generate a commit? It would be great to explain this to the user, as it's integral to playing the game. |
yeah i update Render function to clarify how the game works |
Description
From #2758
This PR introduces a commit-reveal mechanism for the Shifumi game, ensuring players' moves are hidden until both have committed. The off-chain hashing process is required to prevent move visibility before reveal.
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description