Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account for btcec API change #2646

Closed
wants to merge 1 commit into from
Closed

Conversation

deelawn
Copy link
Contributor

@deelawn deelawn commented Jul 31, 2024

Minor fix caused by dependabot upgrading to a new patch version of btcec, but the patch version had a breaking API change.

@deelawn deelawn requested review from jaekwon, moul and a team as code owners July 31, 2024 01:40
@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Jul 31, 2024
@deelawn deelawn changed the title fix signcompact fix: account for btcec API change Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.15%. Comparing base (879c4b6) to head (9fe7d4c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2646      +/-   ##
==========================================
- Coverage   60.16%   60.15%   -0.01%     
==========================================
  Files         560      560              
  Lines       74741    74738       -3     
==========================================
- Hits        44965    44961       -4     
- Misses      26389    26391       +2     
+ Partials     3387     3386       -1     
Flag Coverage Δ
contribs/gnodev 61.40% <ø> (+0.81%) ⬆️
contribs/gnofaucet 15.31% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/logos 20.23% <ø> (+0.35%) ⬆️
tm2 62.04% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deelawn
Copy link
Contributor Author

deelawn commented Jul 31, 2024

Duplicate of #2644 -- closing

@deelawn deelawn closed this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant