feat(gnoclient): Add Transaction and PendingTransaction methods #2643
Conversation
linhpn99
requested review from
zivkovicmilos,
leohhhn and
gfanton
as code owners
github-actions
bot
added
the
📦 ⛰️ gno.land
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2643 +/- ##
==========================================
+ Coverage 60.44% 60.45% +0.01%
==========================================
Files 563 563
Lines 75159 75183 +24
==========================================
+ Hits 45427 45453 +26
+ Misses 26343 26340 -3
- Partials 3389 3390 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
linhpn99
changed the title
linhpn99
force-pushed
the
gnoclient-query-tx
branch
from
d96bda5
to
ddf5e4a
Compare
Kouteki
added
the
review/triage-pending
|
|
||
| // GetTransaction retrieves the transaction details for a given transaction hash | ||
| // The provided hash must be a valid base64 encoded string | ||
| func (c *Client) Transaction(hash string) (*ctypes.ResultTx, error) { |
There was a problem hiding this comment.
The comment says "GetTransaction". Should the function name be GetTransaction?
| // PendingTransaction retrieves unconfirmed transactions from the blockchain | ||
| // The `limit` parameter specifies the maximum number of unconfirmed transactions to return | ||
| // If `limit` is 0, it retrieves all unconfirmed transactions | ||
| func (c *Client) PendingTransaction(limit int) (*ctypes.ResultUnconfirmedTxs, error) { |
There was a problem hiding this comment.
Maybe this should this be named GetPendingTransaction , similar to GetTransaction.
|
@linhpn99 Is this PR still being worked on? |
I'm no longer continuing with this, but I’m sure the others are still waiting for a review and ready to keep developing |
This PR adds functionality for retrieving transaction by hash from the blockchain and handling unconfirmed transactions.This PR includes :
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description