Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fmt): do not print a second line when printing file to stdout #2639

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

gfanton
Copy link
Member

@gfanton gfanton commented Jul 28, 2024

address #2633

Avoid double printing newline when executing gno fmt without the -w (write) flag.

@gfanton gfanton requested a review from tbruyelle July 28, 2024 08:20
@gfanton gfanton self-assigned this Jul 28, 2024
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Jul 28, 2024
Copy link

codecov bot commented Jul 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.39%. Comparing base (0e3c050) to head (bfab6b1).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2639      +/-   ##
==========================================
+ Coverage   54.99%   59.39%   +4.40%     
==========================================
  Files         595      574      -21     
  Lines       79775    75586    -4189     
==========================================
+ Hits        43872    44897    +1025     
+ Misses      32581    27292    -5289     
- Partials     3322     3397      +75     
Flag Coverage Δ
contribs/gnofaucet 15.31% <ø> (+0.85%) ⬆️
gno.land 64.15% <ø> (ø)
gnovm 64.19% <100.00%> (+3.98%) ⬆️
misc/genstd 80.54% <ø> (ø)
misc/logos 20.23% <ø> (+2.85%) ⬆️
tm2 61.88% <ø> (+7.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl
Copy link
Member

thehowl commented Jul 29, 2024

There are failing tests; please address them

Signed-off-by: gfanton <[email protected]>
tbruyelle added a commit to tbruyelle/gnols that referenced this pull request Jul 30, 2024
@thehowl thehowl merged commit 9b11417 into gnolang:master Jul 30, 2024
115 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants