chore(rpcclient): avoid losing jsonrpc information upon non-2xx http codes (fix #2422) #2631
+40
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…codes (fix gnolang#2422) Regardless of HTTP response code, if jsonrpc was received we want to unmarshal and use it as the response (gnolang#2422). Otherwise we get errors such as: --= Error =-- Data: unable to call RPC method abci_query, invalid status code received, 500 Msg Traces: 0 /me/gno/tm2/pkg/crypto/keys/client/query.go:94 - querying --= /Error =-- When a tool like wireshark shows that the following jsonrpc was actually in the 500 message: JSON compact form: {...} "jsonrpc": "2.0" "id": "" "error": {...} "code": -32603 "message": "Internal error" "data": "assignment to entry in nil map" -------------- Discussion: An easy way to fix gnolang#2422 is to simply append the response body in case of an HTTP status > 299. But doing so returns an error. Is this what we want? --------------------------- The table below indicates what to do based on two bool variables: 1. is HTTP code 2xx? 2. can response body be unmarshalled? /--------+------------------+--------------------------------------\ | | jsonrpc | text | |--------+------------------+--------------------------------------| | 2xx | use as response | Error "unable to unmarshal response" | | >=300 | use as response⁺ | Error "invalid status code" | \------------------------------------------------------------------/ In the case marked with ⁺, we prepend a fmt.Print to show the HTTP response code to the user.
grepsuzette
requested review from
jaekwon,
moul,
piux2 and
zivkovicmilos
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2631 +/- ##
==========================================
+ Coverage 54.70% 54.75% +0.05%
==========================================
Files 582 584 +2
Lines 78430 78490 +60
==========================================
+ Hits 42902 42976 +74
+ Misses 32315 32289 -26
- Partials 3213 3225 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an alternative implementation of #2501 to fix #2422.