Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rollback docker go versions for portal loop #2545

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

zivkovicmilos
Copy link
Member

Description

This PR rolls back the docker go library versions, that broke existing deployments due to active Docker version mismatches.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@zivkovicmilos zivkovicmilos self-assigned this Jul 8, 2024
@zivkovicmilos zivkovicmilos requested review from moul and a team as code owners July 8, 2024 08:56
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 54.93%. Comparing base (fafc8f6) to head (422ca64).

Files Patch % Lines
misc/loop/cmd/snapshotter.go 0.00% 3 Missing ⚠️
misc/loop/cmd/portal-loop.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2545   +/-   ##
=======================================
  Coverage   54.93%   54.93%           
=======================================
  Files         594      594           
  Lines       79297    79297           
=======================================
  Hits        43560    43560           
  Misses      32448    32448           
  Partials     3289     3289           
Flag Coverage Δ
misc/autocounterd 0.00% <ø> (ø)
misc/genproto 0.00% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/goscan 0.00% <ø> (ø)
misc/logos 17.38% <ø> (ø)
misc/loop 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zivkovicmilos zivkovicmilos merged commit aec02dc into master Jul 8, 2024
86 of 87 checks passed
@zivkovicmilos zivkovicmilos deleted the dev/zivkovicmilos/rollback-docker branch July 8, 2024 08:59
gfanton pushed a commit to gfanton/gno that referenced this pull request Jul 23, 2024
## Description

This PR rolls back the docker go library versions, that broke existing
deployments due to active Docker version mismatches.

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants