feat: render .md files from packages #2540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2540 +/- ##
==========================================
- Coverage 60.15% 60.15% -0.01%
==========================================
Files 561 561
Lines 74999 74999
==========================================
- Hits 45117 45115 -2
- Misses 26505 26506 +1
- Partials 3377 3378 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
… into feat/md-renderer-package
|
Hey Alexis, thank you! Could you please share some before and after screenshots when making UX changes? We're hoping to have automatic deployment with @gfanton's upcoming refactor and @sw360cab's scripts. Until then, we'll need to manually share the changes to avoid requiring everyone to install and run the tool. |
|
Hey @moul 👋 Here is the current version (live version from gno.land) of a
|
moul
approved these changes
Jul 8, 2024
MikaelVallenet
pushed a commit
to MikaelVallenet/gno
that referenced
this pull request
Aug 17, 2024
<!-- please provide a detailed description of the changes made in this pull request. --> This PR aims to solves gnolang#2494 in order to parse `markdown` files from packages templates. It currently uses the file extension (from `window.location`) to detect if the content is a `md` file in a package template. _Although keeping the extension in the url is not a good practice for SEO & UX (because we are using pretty URLs for some other contents and are not consistent throughout gnoweb), This should do the work for now as short term solution since we are gonna parse `.md` from `go` soon with the new gnoweb design/codebase refactor (cc @gfanton)._ It also improves the package file template by removing global JS and pushing the `source` content into the main rendering flow from `renderer.js`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to solves #2494 in order to parse
markdownfiles from packages templates. It currently uses the file extension (fromwindow.location) to detect if the content is amdfile in a package template.Although keeping the extension in the url is not a good practice for SEO & UX (because we are using pretty URLs for some other contents and are not consistent throughout gnoweb), This should do the work for now as short term solution since we are gonna parse
.mdfromgosoon with the new gnoweb design/codebase refactor (cc @gfanton).It also improves the package file template by removing global JS and pushing the
sourcecontent into the main rendering flow fromrenderer.js.