Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Dev/jae/crossrealm #2535

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

WIP Dev/jae/crossrealm #2535

wants to merge 8 commits into from

Conversation

jaekwon
Copy link
Contributor

@jaekwon jaekwon commented Jul 7, 2024

Fixing crossrealm pointer persistence issues.

go run github.com/gnolang/gno/gnovm/cmd/gno test -v --update-golden-tests --print-runtime-metrics ./examples/gno.land/r/demo/foo20

Addresses #2526

@jaekwon jaekwon requested review from thehowl, moul, piux2, deelawn, mvertes and a team as code owners July 7, 2024 16:54
@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related labels Jul 7, 2024
Copy link

codecov bot commented Jul 7, 2024

Codecov Report

Attention: Patch coverage is 64.58333% with 17 lines in your changes missing coverage. Please review.

Project coverage is 54.90%. Comparing base (b1d778c) to head (a91c84a).
Report is 6 commits behind head on master.

Files Patch % Lines
gnovm/pkg/gnolang/realm.go 35.29% 9 Missing and 2 partials ⚠️
gnovm/pkg/gnolang/machine.go 68.42% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2535      +/-   ##
==========================================
+ Coverage   54.88%   54.90%   +0.02%     
==========================================
  Files         592      594       +2     
  Lines       79232    79338     +106     
==========================================
+ Hits        43487    43563      +76     
- Misses      32460    32472      +12     
- Partials     3285     3303      +18     
Flag Coverage Δ
contribs/gnodev 23.15% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (ø)
contribs/gnokeykc 0.00% <ø> (ø)
contribs/gnomd 0.00% <ø> (ø)
gnovm 60.21% <64.58%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moul moul added the don't merge Please don't merge this functionality temporarily label Jul 8, 2024
@moul moul mentioned this pull request Jul 9, 2024
@moul moul marked this pull request as draft August 28, 2024 17:22
@moul
Copy link
Member

moul commented Aug 28, 2024

@moul
Copy link
Member

moul commented Aug 29, 2024

Blocked by #2743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
don't merge Please don't merge this functionality temporarily 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: No status
Status: Backlog
Development

Successfully merging this pull request may close these issues.

2 participants