-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(timeline): correct updating of reminders and reasons for waiting … #18915
Draft
MyvTsv
wants to merge
12
commits into
glpi-project:10.0/bugfixes
Choose a base branch
from
MyvTsv:ticket36212
base: 10.0/bugfixes
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+419
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonebuzz
reviewed
Feb 5, 2025
Rom1-B
suggested changes
Feb 5, 2025
Rom1-B
suggested changes
Feb 7, 2025
AdrienClairembault
approved these changes
Feb 12, 2025
Rom1-B
approved these changes
Feb 12, 2025
I put back this PR to draft. Waiting a couple of days before merging 10.0.19 changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
If the reason for waiting is changed via a follow-up, the date of publication of the follow-up will be the new initial date to perform the reminders. Before, the initial date was unchanged. It remained the publication date of the ticket holder.
To change a reason for waiting without losing the time already elapsed, it will be necessary to select the reason for waiting by modifying the tracking that generated it.