Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(timeline): correct updating of reminders and reasons for waiting … #18915

Draft
wants to merge 12 commits into
base: 10.0/bugfixes
Choose a base branch
from

Conversation

MyvTsv
Copy link
Contributor

@MyvTsv MyvTsv commented Feb 4, 2025

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes !36212
  • This PR changes the behavior when changing the reason of expectations in a ticket already pending.

If the reason for waiting is changed via a follow-up, the date of publication of the follow-up will be the new initial date to perform the reminders. Before, the initial date was unchanged. It remained the publication date of the ticket holder.

To change a reason for waiting without losing the time already elapsed, it will be necessary to select the reason for waiting by modifying the tracking that generated it.

@MyvTsv MyvTsv requested review from stonebuzz and Rom1-B February 4, 2025 14:35
@MyvTsv MyvTsv self-assigned this Feb 4, 2025
@Rom1-B Rom1-B removed request for stonebuzz and Rom1-B February 5, 2025 08:40
@MyvTsv MyvTsv marked this pull request as ready for review February 5, 2025 08:44
src/PendingReason_Item.php Outdated Show resolved Hide resolved
src/PendingReason_Item.php Outdated Show resolved Hide resolved
phpunit/functional/PendingReasonTest.php Outdated Show resolved Hide resolved
@MyvTsv MyvTsv requested review from stonebuzz and Rom1-B February 6, 2025 15:16
@Rom1-B Rom1-B added this to the 10.0.19 milestone Feb 10, 2025
@cedric-anne
Copy link
Member

I put back this PR to draft. Waiting a couple of days before merging 10.0.19 changes.

@cedric-anne cedric-anne marked this pull request as draft February 12, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants