Included Unity Package definition #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for contributing! This is a very welcome addition to the library. |
|
You bet! Thanks to you for this amazing service! |
a1rwulf
approved these changes
Apr 23, 2021
| ### Submitting Scores | ||
| To submit a player score instatiante a object, add the values and call Share() | ||
| To submit a player score instantiate a object, add the values and call Share() |
| @@ -86,7 +101,7 @@ void CallbackMethod(Leaderboard leaderboard){ | |||
| } | |||
| ``` | |||
|
|
|||
| In this case we want the leaderboard of the GTD score. The limit is the number players you want to fetch, which has to be between 1 and 100. | |||
| In this case we want the leaderboard of the GTD score. The limit is the number players you want to fetch, which has to be between 1 and 100. | |||
There was a problem hiding this comment.
the number of players you want to fetch...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes made in this PR don't touch the code in the library.
Instead, the files included offer the possibility to include the library in any Unity project as a package using the Package Manager, and avoiding the need to manually download and import the CS file; later changes made in the library can be pulled easily using the Package Manager (again, no need to come back to the repo, download, and import).
As a brief summary of the changes:
package.jsonfile describes the package and it's the one that actually allows importing the whole repository as a Unity Package using only the GitHub URL of the repository.io.globalstats.unity.asmdeffile forces the script (or scripts if the library had more than 1) to be precompiled in its own assembly when it's imported, so when users make changes to their own code, this library is not recompiled each time. Besides, it's required by the Package Manager to make the library a package.It's worth noting that even with these changes, users can still grab the cs file directly from the repo and manually import it, as they've been doing until now, if they want; only they'll lose the benefits described above.