[WIP] Begin moving towards invokable wire format #1690
+15,785
−6,978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wycats
force-pushed
the
feature/emit-fn-calls
branch
2 times, most recently
from
cc230f3 to
4625e5e
Compare
wycats
force-pushed
the
feature/emit-fn-calls
branch
from
a5f57d9 to
cddc4dc
Compare
wycats
force-pushed
the
feature/emit-fn-calls
branch
from
6a5d569 to
87e01ac
Compare
NullVoxPopuli
added a commit
that referenced
this pull request
Feb 20, 2025
NullVoxPopuli
added a commit
that referenced
this pull request
Feb 20, 2025
NullVoxPopuli
added a commit
that referenced
this pull request
Feb 20, 2025
NullVoxPopuli
added a commit
that referenced
this pull request
Feb 20, 2025
Merged
wycats
force-pushed
the
feature/emit-fn-calls
branch
from
a76c67a to
3717287
Compare
- Eliminate special high-level opcodes - By modifying the statements and expressions to use the new encoder APIs, it will be easier for us to emit the encoder calls directly from the wire format - Split modifier and component to resolved variants - Clarify args wire format - Separate kinds of component invocations - Disentangle the types of helpers - Streamline components
wycats
force-pushed
the
feature/emit-fn-calls
branch
from
3717287 to
ada19a6
Compare
The only remaining test failures are syntax errors that need updated test assertions.
wycats
force-pushed
the
feature/emit-fn-calls
branch
from
0683762 to
9ba08a7
Compare
- `strict-mode.ts` now type checks. - Next step: deriving error messages from the validation contexts.
Merged
TODO: consolidate error propagation through elements.
The only remaining failures are now outdated error message tests.
Syntax errors are now notes in the AST rather than reported during parse time, and are reported at compile-time. To make it possible to get syntax errors purely from `@glimmer/syntax`, this commit adds a verifier to `@glimmer/syntax` that validates the standalone `ASTv2` and reports errors that it finds. To get a complete picture, you really _do_ want to wait until compile-time, which can report keyword-specific errors, but this makes it possible to get a sense of the syntax errors without involving the compiler. This is all in service of making errors reported by `@glimmer/syntax` fully forgiving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.