Improve benchmark setup, consistently rely on publishConfig #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit has two related changes: 1. Clean up and document recent changes in the benchmark script. One of these changes is replacing ad-hoc rewrites of `package.json` files with a firm reliance on the `publishConfig` field, which should be reliable (since that's what we use when actually publishing). 2. Update all of the `package.json` files for published packages to have consistent `publishConfig` fields. This change also removed a bunch of historical cruft from the `package.json` files, which helped us to support environments during the ecosystem transition to package.json `exports` fields.
wycats
force-pushed
the
infra/improve-bench-setup-pt2
branch
from
f60a21c
to
dde2390
Compare
This was referenced Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two related changes:
package.jsonfiles with a firm reliance on thepublishConfigfield, which should be reliable (since that's what we use when actually publishing).package.jsonfiles for published packages to have consistentpublishConfigfields. This change also removed a bunch of historical cruft from thepackage.jsonfiles, which helped us to support environments during the ecosystem transition to package.jsonexportsfields.