Streamline append VM implementation #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
approved these changes
Oct 31, 2024
NullVoxPopuli
requested changes
Oct 31, 2024
|
I ran it twice
|
wycats
force-pushed
the
infra/streamline-append-vm
branch
from
fa98cf2
to
4da86b9
Compare
The fact that the build was conflating two unrelated Stack types is a bug, and we'll fix it by using the standard rollup plugin soon. For now, we're going to work around it by renaming the internal Stack type in VM to VmStack.
wycats
force-pushed
the
infra/streamline-append-vm
branch
from
2742428
to
c72b394
Compare
NullVoxPopuli
approved these changes
Nov 2, 2024
|
We both tested this locally, and perf is fine |
This was referenced Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to pull out the commit that doesn't seem to have a standalone performance impact so we can land it separately.