Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from const enums to consts #1645

Merged
merged 15 commits into from
Nov 5, 2024
Merged

Move from const enums to consts #1645

merged 15 commits into from
Nov 5, 2024

Commits on Nov 3, 2024

  1. Remove some enums

    @wycats
    wycats committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    5620f26 View commit details
    Browse the repository at this point in the history

  2. Remove enums 

    Historically, many of these enums used `const enum`s, which at least had
the benefit of being compiled away at build time.

We've now moved to mostly normal `enum`s, which are both less efficient
than normal constants, and a relic of an earlier TypeScript era before
literal types.

This PR moves all enums to normal constants, and creates types for the
constant values when the code needs them.
    @wycats
    wycats committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    77cc0d0 View commit details
    Browse the repository at this point in the history

  3. Adopt improved terminology and tracing infra

    @wycats
    wycats committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    00e8785 View commit details
    Browse the repository at this point in the history

  4. A bunch of improvements

    @wycats
    wycats committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    5d1f5dc View commit details
    Browse the repository at this point in the history

  5. Extract constants into inlinable package

    @wycats
    wycats committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    588b2dc View commit details
    Browse the repository at this point in the history

  6. Remove rollup config from inline packages

    @wycats
    wycats committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    5cb088a View commit details
    Browse the repository at this point in the history

  7. Put @glimmer/debug-util in dev deps

    @wycats
    wycats committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    5a315d3 View commit details
    Browse the repository at this point in the history

  8. Improve benchmark

    @wycats
    wycats committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    eb64adc View commit details
    Browse the repository at this point in the history

  9. Update package.jsons

    @wycats
    wycats committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    b49b6e9 View commit details
    Browse the repository at this point in the history

  10. Remove register indirection

    @wycats
    wycats committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    19e63a2 View commit details
    Browse the repository at this point in the history

  11. Move machine opcodes to constants

    @wycats
    wycats committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    e18b5b6 View commit details
    Browse the repository at this point in the history

  12. Move remaining opcodes to constants

    @wycats
    wycats committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    cdf810e View commit details
    Browse the repository at this point in the history

  13. Merge remote-tracking branch 'origin/main' into feature/error-recover… 

    …y-redux-pt3
    @wycats
    wycats committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    b10d437 View commit details
    Browse the repository at this point in the history

  14. Remove pointless alias

    @wycats
    wycats committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    d65631b View commit details
    Browse the repository at this point in the history

  15. Remove incorrect constants re-export from compiler

    @wycats
    wycats committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    5636a8f View commit details
    Browse the repository at this point in the history