-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plumb debug symbols when using lexical scope #1634
Conversation
This change introduces a new `emit.debugSymbols` option that can be used to enable debug symbols when using lexical scope.
3b9e91b
to
90a1331
Compare
duration phase no difference [-308ms to 72ms] [16:50:23] Generating Benchmark Reports [started]
JSON: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/compare.json PDF: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/artifact-1.pdf HTML: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/artifact-1.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving because in 3 benches, it seems this change has no impact
.. and i probably need to run benches locally because we're not able to trust the stability of the results.
This case is not fixed by the current PR: ``` <p {{some.modifier}}> ``` It probably *should* result in `some.modifier` appearing as the `name` in the debug modifier tree, but the codepaths improved in the current PR don't fix that case. For this PR, we'll use the debug name provided by the modifier manager, which is at least not a regression. A future PR should systematically fix all of the cases that end up in the debug tree so that they *always* show "what the user typed", regardless of how it got converted into running code.
This change introduces a new
emit.debugSymbols
option that can be used to enable debug symbols when using lexical scope.