Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plumb debug symbols when using lexical scope #1634

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Conversation

wycats
Copy link
Contributor

@wycats wycats commented Oct 16, 2024

This change introduces a new emit.debugSymbols option that can be used to enable debug symbols when using lexical scope.

This change introduces a new `emit.debugSymbols` option that can be used
to enable debug symbols when using lexical scope.
Copy link

github-actions bot commented Oct 18, 2024

duration phase no difference [-308ms to 72ms]
renderEnd phase no difference [-2ms to 2ms]
render1000Items1End phase no difference [-26ms to 3ms]
clearItems1End phase no difference [-3ms to 2ms]
render1000Items2End phase no difference [-32ms to 0ms]
clearItems2End phase no difference [-1ms to 1ms]
render5000Items1End phase no difference [-97ms to 4ms]
clearManyItems1End phase no difference [-6ms to 6ms]
render5000Items2End phase no difference [-80ms to 31ms]
clearManyItems2End phase no difference [-3ms to 3ms]
render1000Items3End phase no difference [-33ms to 17ms]
append1000Items1End phase no difference [-19ms to 15ms]
append1000Items2End phase no difference [-30ms to 13ms]
updateEvery10thItem1End phase no difference [-2ms to 16ms]
updateEvery10thItem2End phase no difference [-5ms to 1ms]
selectFirstRow1End phase no difference [0ms to 0ms]
selectSecondRow1End phase no difference [-1ms to 0ms]
removeFirstRow1End phase no difference [-6ms to 3ms]
removeSecondRow1End phase no difference [-16ms to 1ms]
swapRows1End phase no difference [-15ms to 0ms]
swapRows2End phase no difference [-2ms to 0ms]
clearItems4End phase estimated regression +4ms [1ms to 8ms] OR +2.85% [0.66% to 5.09%]
paint phase no difference [0ms to 0ms]

[16:50:23] Generating Benchmark Reports [started]
[16:50:32] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-vm/glimmer-vm/tracerbench-results/artifact-1.html

Copy link
Contributor

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some lint fixes are needed, also this PR demonstrates a performance regression

image

@NullVoxPopuli
Copy link
Contributor

Now the bench says things are faster...

image

Copy link
Contributor

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because in 3 benches, it seems this change has no impact

.. and i probably need to run benches locally because we're not able to trust the stability of the results.

This case is not fixed by the current PR:

```
<p {{some.modifier}}>
```

It probably *should* result in `some.modifier` appearing as the `name`
in the debug modifier tree, but the codepaths improved in the current PR
don't fix that case. For this PR, we'll use the debug name provided by
the modifier manager, which is at least not a regression.

A future PR should systematically fix all of the cases that end up in
the debug tree so that they *always* show "what the user typed",
regardless of how it got converted into running code.
@wycats wycats merged commit 11a8e18 into main Oct 28, 2024
6 checks passed
@wycats wycats deleted the feature/debug-symbols branch October 28, 2024 18:39
@github-actions github-actions bot mentioned this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants