Skip to content

Commit

Permalink
Merge pull request #1615 from glimmerjs/when-generating-the-lockfile-…
Browse files Browse the repository at this point in the history
…dont-let-puppeteer-do-things

When generating the release plan, we don't need to run the puppeteer install -- so we can use --ignore-scripts
  • Loading branch information
NullVoxPopuli authored Sep 11, 2024
2 parents 48c5eb1 + 6d965b8 commit 2e13115
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
steps:
- uses: wyvox/action@v1
with:
pnpm-args: '--ignore-scripts'
node-version: 20.1.0
repo-token: ${{ secrets.GITHUB_TOKEN }}
- run: pnpm turbo build
Expand All @@ -37,6 +38,7 @@ jobs:
steps:
- uses: wyvox/action@v1
with:
pnpm-args: '--ignore-scripts'
node-version: 20.1.0
repo-token: ${{ secrets.GITHUB_TOKEN }}
- run: pnpm lint
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/plan-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ jobs:
ref: 'main'
- uses: wyvox/action-setup-pnpm@v3
with:
pnpm-args: '--ignore-scripts'
node-version: 20.1.0

- name: "Generate Explanation and Prep Changelogs"
Expand Down

0 comments on commit 2e13115

Please sign in to comment.