Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure an ID token is valid before attempting to get a refresh token #540

Merged
merged 4 commits into from
Aug 25, 2022

Conversation

kmjennison
Copy link
Contributor

In addition, call onVerifyTokenError when an ID token is invalid and we cannot refresh it.

Closes #531. Improved debug logs were added in #534.

@vercel
Copy link

vercel bot commented Aug 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nfa-example ✅ Ready (Inspect) Visit Preview Aug 25, 2022 at 8:13PM (UTC)

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #540 (7b02724) into v1.x (4abfd12) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

❗ Current head 7b02724 differs from pull request most recent head 2b2aa05. Consider uploading reports for the commit 2b2aa05 to get more accurate results

@@            Coverage Diff             @@
##             v1.x     #540      +/-   ##
==========================================
- Coverage   99.39%   99.26%   -0.13%     
==========================================
  Files          30       30              
  Lines         659      682      +23     
  Branches      218      225       +7     
==========================================
+ Hits          655      677      +22     
- Misses          4        5       +1     
Impacted Files Coverage Δ
src/firebaseAdmin.js 98.73% <100.00%> (-0.04%) ⬇️
src/setAuthCookies.js 100.00% <100.00%> (ø)
src/cookies.js 97.77% <0.00%> (-2.23%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant