-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement cookies.unified option to use unified cookie #192
implement cookies.unified option to use unified cookie #192
Conversation
a single unified cookie is required in order to make server side authentication work in firebase hosting scenarions. since firebase hosting only allows you to use on single cookie; cookies.signed will default to false when cookies.unified is set to true - related to github.com/gladly-team/issues/190
This would greatly simplify work we do for a project and for which we’re currently using |
While this looks like a fine workaround for people who need it, I don't think it makes sense to merge into the main package. My main concerns are:
|
@kmjennison I see your concerns. I'd love to make the unified cookie the default behaviour—but I also see this is becoming a larger work package, since how I understand the |
@kmjennison a comment on my reply to
would have been appreciated 👍 |
@maerzhase Sorry, I didn't mean to ignore you here, just closing to move the discussion to #190. I agree that supporting a single cookie makes sense. Cookie signing still makes sense within a single value (like how JSON web tokens work)—we'd just need to use a cookies library that supports it. |
cool! thank's a lot! I will try to offer my support! have a good one! |
This PR implements a very basic solution to save authentication cookies in one single
unified
cookie. This can be used in scenarios where only a single cookie is allowed, e.g. firebase hosting (see #190).I already tested this version on a deployment with cloud.run + firebase hosting and it works when the cookie is name
__session
. (as mentioned in their documentation)I consider this solution the most straightforward approach I could offer—but please point me in the right directions to get his feature merged!
__session
, for Firebase hosting #190