[server] make gRPC clients viable in non-HTTP/2-compatible environments #20565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tool: gitpod/catfood.gitpod.cloud
geropl
reviewed
Jan 30, 2025
| @@ -17,7 +17,7 @@ schema: |- | |||
|
|
|||
| permission make_admin = installation->admin + organization->installation_admin | |||
|
|
|||
| // administrate is for changes such as blocking or verifiying, i.e. things that only admins can do on user | |||
| // administrate is for changes such as blocking or verifying, i.e. things that only admins can do on user | |||
There was a problem hiding this comment.
Let's not change this if not needed, I'm 95% sure it will trigger a spicedb rollover which I'd like to avoid, because it has the tendency to take long time to cycle and not behave well in the meantim.
There was a problem hiding this comment.
Oh right, good point! Will revert to not cause unnecessary trouble
There was a problem hiding this comment.
Addressed in bda0663 (#20565)
geropl
reviewed
Jan 30, 2025
| @@ -39,6 +39,7 @@ export class PrebuildUpdater { | |||
| const span = TraceContext.startSpan("updatePrebuiltWorkspace", ctx); | |||
| try { | |||
| const prebuild = await this.workspaceDB.trace({ span }).findPrebuildByWorkspaceID(status.metadata!.metaId!); | |||
| const workspace = await this.workspaceDB.trace({ span }).findById(workspaceId); | |||
There was a problem hiding this comment.
It's a bit weird that PrebuiltWorkspace has a projectId but no organizationId... 😬 But it is what it is I guess.
geropl
reviewed
Jan 30, 2025
geropl
reviewed
Jan 30, 2025
geropl
reviewed
Jan 30, 2025
geropl
approved these changes
Jan 30, 2025
Co-authored-by: Gero Posmyk-Leinemann <[email protected]> Tool: gitpod/catfood.gitpod.cloud
filiptronicek
commented
Jan 30, 2025
| @@ -241,7 +187,8 @@ function createServiceClient<T extends ServiceType>( | |||
| } | |||
| return (async function* () { | |||
| try { | |||
| const client = await resolveClient(); | |||
| // for server streaming, we prefer jsonRPC | |||
There was a problem hiding this comment.
for future reference: the only streaming methods we implement in our public api v1 are:
WorkspaceService.WatchWorkspaceStatusPrebuildService.WatchPrebuild
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes a couple of related changes:
disableWebsocketPrebuildUpdates, and instead introduces a by-organization subscription for prebuild updates. This makes the listening much more efficient (requiring way fewer listeners) and scales well even with thousands of projects. Permission-wise, it relies on the organization'sread_prebuildpermission.Related Issue(s)
Fixes CLC-1106
How to test