-
Notifications
You must be signed in to change notification settings - Fork 0
[gitpod-network-check] Introduce lambda and local runners #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
@nandajavarma or @kylos101 Would be awesome if you could do a review here. Basically follow the test steps above. |
@geropl how do we manually do cleanup, like if the ec2 or lambda runner partially install, but fail or just need to be deleted manually after being run? I checked to see if there's a cleanup command, but get an error when using
At the moment, the build is failing (a couple old go files are broke, cleanup.go and checks.go):
I'll test in catfood (private) and demo (public) next, and then review code. |
Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
f920be1
to
e819571
Compare
e819571
to
225cb7b
Compare
Build fix, and has CI workflow now. |
Description
This is a PR to cleanup the grown code base a little, and extract the tests we run, and the EC2TestRunner we have right now.
Goals:
genie
for instance 💡Related Issue(s)
Fixes CLC-1285
How to test
gitpod-network-check --runner=ec2
gitpod-network-check --runner=lamda
Documentation
/hold