Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up after hyper 1.x update #8

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Conversation

jorendorff
Copy link
Contributor

In this PR:

  • Add some missing comments
  • Fix a bug around SERVICE_FQN: every URL used with a router needs to start with /
  • Add TwirpRouterBuilder to make code generation (and the generated code) simpler
  • Remove pub from a few things the library doesn't really need to expose

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@jorendorff jorendorff requested a review from a team as a code owner January 25, 2024 15:43
@jorendorff jorendorff merged commit eee91a5 into main Jan 25, 2024
1 check passed
@jorendorff jorendorff deleted the jorendorff/axum-encapsulate branch January 25, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants