Swap FluentAssertions with xUnit assertions #1323
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results858 tests 858 ✅ 20s ⏱️ Results for commit 6c8b7ab. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were using FluentAssertions as our library of choice for almost all of our unit tests. Unfortunately for the latest version 8, they are switching their license from
Apache 2to a paid for commercial use so we will not be able to upgrade to the latest version (>= 8)! For now we can keep staying on < 8 but eventually we should probably move away from using it and switch to a different library like shoudly or we can usexUnit's built in assertions.With
xUnitbeing a part of the.NET Foundationthere is fairly less risk of any dramatic OSS license changes, I think it would be better to just switch toxUnit's built assertions which has a very readable and straightforward. I started with changing theMigrateRepoCommandHandlerTests.csforgeiand realized that it was very fairly easy to switch but given our sheer number of unit tests it is going to take some time to completely switch though.ThirdPartyNotices.txt(if applicable)