JS: got package modeling
#19091
Merged
JS: got package modeling
#19091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…handling of `got` instances and options retrieval.
There was a problem hiding this comment.
Pull Request Overview
This PR models the behavior of the got package by defining its Options type, paginate(), and extend() functions.
- Added test cases demonstrating various usages of Options, paginate(), and extend() in the test file.
- Updated the change notes to reflect the improved support for the got package.
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| javascript/ql/test/library-tests/frameworks/ClientRequests/tst.js | Added tests for got's Options type and method chaining with extend() and paginate() |
| javascript/ql/lib/change-notes/2025-03-24-got-package.md | Updated change notes to document the new support for the got package |
Files not reviewed (2)
- javascript/ql/lib/semmle/javascript/frameworks/ClientRequests.qll: Language not supported
- javascript/ql/test/library-tests/frameworks/ClientRequests/ClientRequests.expected: Language not supported
Tip: Leave feedback on Copilot's review comments with the 👎 and 👍 buttons to help improve review quality. Learn more
javascript/ql/test/library-tests/frameworks/ClientRequests/tst.js
Outdated
Show resolved
Hide resolved
asgerf
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR models got's
Optionstype,paginate(), andextend()functions, modeling their behavior.