JS: QL-side type/name resolution for TypeScript and JSDoc #19078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Some changes that I backed out caused a bad join in this code, but I'd like to keep the fix.
asgerf
force-pushed
the
js/name-resolution
branch
from
cee75ae to
fa3e5ed
Compare
| } | ||
|
|
||
| /** Helps track flow from a particular set of source nodes. */ | ||
| module Track<nodeSig/1 isSource> { |
Check warning
Code scanning / CodeQL
Dead code Warning
| target = cls.getConstructor().getBody() | ||
| ) | ||
| or | ||
| valueHasType(call.(InvokeExpr).getCallee(), trackFunctionValue(target)) |
Check warning
Code scanning / CodeQL
Redundant cast Warning
| or | ||
| valueHasType(call.(InvokeExpr).getCallee(), trackFunctionValue(target)) | ||
| or | ||
| valueHasType(call.(InvokeExpr).getCallee(), trackFunctionType(target)) and |
Check warning
Code scanning / CodeQL
Redundant cast Warning
| ) | ||
| or | ||
| exists(InterfaceDefinition interface, CallSignature sig | | ||
| valueHasType(call.(InvokeExpr).getCallee(), trackType(interface)) and |
Check warning
Code scanning / CodeQL
Redundant cast Warning
This reverts commit 385e663.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.