Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: Update CompLog dependency to 0.9.8 #19070

Merged
merged 1 commit into from
Mar 25, 2025
Merged

Conversation

tamasvajk
Copy link
Contributor

@tamasvajk tamasvajk commented Mar 20, 2025

This pull request updates the version of the Basic.CompilerLog.Util package to version 0.9.8.

@github-actions github-actions bot added the C# label Mar 20, 2025
@tamasvajk tamasvajk marked this pull request as ready for review March 24, 2025 10:02
@Copilot Copilot bot review requested due to automatic review settings March 24, 2025 10:02
@tamasvajk tamasvajk requested review from a team as code owners March 24, 2025 10:02
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • csharp/paket.dependencies: Language not supported
  • csharp/paket.main.bzl: Language not supported

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelnebel
Copy link
Contributor

@tamasvajk : May I ask, if there is a reason for updating the CompLog pack. Is there something with binlog extraction that doesn't work as expected?

@tamasvajk
Copy link
Contributor Author

@tamasvajk : May I ask, if there is a reason for updating the CompLog pack. Is there something with binlog extraction that doesn't work as expected?

@DmitriyShepelev requested this change.

@DmitriyShepelev
Copy link

The update specifically includes these two fixes:

Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tamasvajk tamasvajk merged commit 36ed96f into github:main Mar 25, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants