Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Minimum Permissions Map #18517

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions actions/ql/lib/codeql/actions/config/Config.qll
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,18 @@ predicate vulnerableActionsDataModel(
*/
predicate immutableActionsDataModel(string action) { Extensions::immutableActionsDataModel(action) }

/**
* MaD models for minimum permissions for actions
* Fields:
* - action: action name
* - minimum_permissions: list of minimum permissions
*/
predicate minimumPermissionsDataModel(
string action, string minimum_permissions
) {
Extensions::minimumPermissionsDataModel(action, minimum_permissions)
}

/**
* MaD models for untrusted git commands
* Fields:
Expand Down
5 changes: 5 additions & 0 deletions actions/ql/lib/codeql/actions/config/ConfigExtensions.qll
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@ extensible predicate vulnerableActionsDataModel(
*/
extensible predicate immutableActionsDataModel(string action);

/**
* Holds for actions that have a minimum permissions definition.
*/
extensible predicate minimumPermissionsDataModel(string action, string minimum_permissions);

/**
* Holds for git commands that may introduce untrusted data when called on an attacker controlled branch.
*/
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import actions
class MinimumActionsPermissions extends UsesStep {
string action;
string minimum_permissions;

MinimumActionsPermissions() {
minimumPermissionsDataModel(action, minimum_permissions) and
this.getCallee() = action
}

string getMinimumPermissions() { result = minimum_permissions }

string getAction() { result = action }
}
Loading