Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autofix reminder #17017

Closed
wants to merge 1 commit into from
Closed

Add autofix reminder #17017

wants to merge 1 commit into from

Conversation

aeisenberg
Copy link
Contributor

Remind query authors to validate their changes in autofix before merging.

@aeisenberg aeisenberg requested a review from a team as a code owner July 18, 2024 20:04
@aeisenberg aeisenberg marked this pull request as draft July 18, 2024 20:05
@aeisenberg aeisenberg added acknowledged GitHub staff acknowledges this issue Autofix Validation Required Validating how this change affects autofix is required before merging. No Autofix Validation Required Validating how this change affects autofix is NOT required before merging. and removed acknowledged GitHub staff acknowledges this issue Autofix Validation Required Validating how this change affects autofix is required before merging. No Autofix Validation Required Validating how this change affects autofix is NOT required before merging. labels Jul 18, 2024
@aeisenberg aeisenberg force-pushed the aeisenberg/autofix-reminder branch 3 times, most recently from 7f1cf4b to 04be271 Compare July 18, 2024 23:22
@aeisenberg aeisenberg added Autofix Validation Required Validating how this change affects autofix is required before merging. and removed Autofix Validation Required Validating how this change affects autofix is required before merging. labels Jul 18, 2024
@github-actions github-actions bot added the Autofix Validation Required Validating how this change affects autofix is required before merging. label Jul 18, 2024
Copy link
Contributor

This pull request updates , , or files, Please validate that autofixes generated based on these changes are valid. See the documentation (internal access required). If autofix validation is not required, please add the label 'No Autofix Validation Required' to this pull request.

@aeisenberg aeisenberg removed the Autofix Validation Required Validating how this change affects autofix is required before merging. label Jul 29, 2024
@aeisenberg aeisenberg marked this pull request as ready for review July 29, 2024 18:33
@github-actions github-actions bot added the Autofix Validation Required Validating how this change affects autofix is required before merging. label Jul 29, 2024
Copy link
Contributor

This pull request updates '.ql', '.qll', or '.qhelp' files, Please validate that autofixes generated based on these changes are valid. See the documentation (internal access required). If autofix validation is not required, please add the label 'No Autofix Validation Required' to this pull request.

@aeisenberg aeisenberg added No Autofix Validation Required Validating how this change affects autofix is NOT required before merging. and removed No Autofix Validation Required Validating how this change affects autofix is NOT required before merging. labels Jul 29, 2024
@aeisenberg aeisenberg added No Autofix Validation Required Validating how this change affects autofix is NOT required before merging. and removed No Autofix Validation Required Validating how this change affects autofix is NOT required before merging. labels Aug 8, 2024
Remind query authors to validate their changes in autofix before merging.
@esbena esbena self-requested a review August 13, 2024 10:35
@esbena
Copy link
Contributor

esbena commented Aug 13, 2024

(pending internal discussion)

@aeisenberg
Copy link
Contributor Author

Not going with this approach.

@aeisenberg aeisenberg closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Autofix Validation Required Validating how this change affects autofix is required before merging. No Autofix Validation Required Validating how this change affects autofix is NOT required before merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants