[spike] Add integration tests

GitHubVS.sln

@@ -125,6 +125,8 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "GitHub.VisualStudio.UnitTes
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "GitHub.Resources", "src\GitHub.Resources\GitHub.Resources.csproj", "{54E8D71A-AABB-4698-95FE-7F11612B8E59}"
 EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "IntegrationTests", "test\IntegrationTests\IntegrationTests.csproj", "{BF6D17FE-15FD-401C-B5D7-DE21837231F1}"
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
@@ -504,6 +506,16 @@ Global
 		{54E8D71A-AABB-4698-95FE-7F11612B8E59}.Release|Any CPU.Build.0 = Release|Any CPU
 		{54E8D71A-AABB-4698-95FE-7F11612B8E59}.ReleaseWithoutVsix|Any CPU.ActiveCfg = Release|Any CPU
 		{54E8D71A-AABB-4698-95FE-7F11612B8E59}.ReleaseWithoutVsix|Any CPU.Build.0 = Release|Any CPU
+		{BF6D17FE-15FD-401C-B5D7-DE21837231F1}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{BF6D17FE-15FD-401C-B5D7-DE21837231F1}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{BF6D17FE-15FD-401C-B5D7-DE21837231F1}.DebugCodeAnalysis|Any CPU.ActiveCfg = Debug|Any CPU
+		{BF6D17FE-15FD-401C-B5D7-DE21837231F1}.DebugCodeAnalysis|Any CPU.Build.0 = Debug|Any CPU
+		{BF6D17FE-15FD-401C-B5D7-DE21837231F1}.DebugWithoutVsix|Any CPU.ActiveCfg = Debug|Any CPU
+		{BF6D17FE-15FD-401C-B5D7-DE21837231F1}.DebugWithoutVsix|Any CPU.Build.0 = Debug|Any CPU
+		{BF6D17FE-15FD-401C-B5D7-DE21837231F1}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{BF6D17FE-15FD-401C-B5D7-DE21837231F1}.Release|Any CPU.Build.0 = Release|Any CPU
+		{BF6D17FE-15FD-401C-B5D7-DE21837231F1}.ReleaseWithoutVsix|Any CPU.ActiveCfg = Release|Any CPU
+		{BF6D17FE-15FD-401C-B5D7-DE21837231F1}.ReleaseWithoutVsix|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE
@@ -534,6 +546,7 @@ Global
 		{DE704BBB-6EC6-4173-B695-D9EBF5AEB092} = {8A7DA2E7-262B-4581-807A-1C45CE79CDFD}
 		{93778A89-3E58-4853-B772-948EBB3F17BE} = {8A7DA2E7-262B-4581-807A-1C45CE79CDFD}
 		{8B14F90B-0781-465D-AB94-19C8C56E3A94} = {8A7DA2E7-262B-4581-807A-1C45CE79CDFD}
+		{BF6D17FE-15FD-401C-B5D7-DE21837231F1} = {8A7DA2E7-262B-4581-807A-1C45CE79CDFD}
 	EndGlobalSection
 	GlobalSection(ExtensibilityGlobals) = postSolution
 		SolutionGuid = {556014CF-5B35-4CE5-B3EF-6AB0007001AC}

src/GitHub.TeamFoundation.14/Services/VSGitExt.cs

@@ -12,7 +12,6 @@
 using Microsoft.VisualStudio.Threading;
 using Microsoft.VisualStudio.TeamFoundation.Git.Extensibility;
 using Task = System.Threading.Tasks.Task;
-using static Microsoft.VisualStudio.VSConstants;
 
 namespace GitHub.VisualStudio.Base
 {
@@ -52,9 +51,15 @@ public VSGitExt(IAsyncServiceProvider asyncServiceProvider, IVSUIContextFactory
             // Start with empty array until we have a chance to initialize.
             ActiveRepositories = Array.Empty<ILocalRepositoryModel>();
 
-            // Initialize when we enter the context of a Git repository
-            var context = factory.GetUIContext(UICONTEXT.RepositoryOpen_guid);
-            context.WhenActivated(() => JoinableTaskFactory.RunAsync(InitializeAsync).Task.Forget(log));
+            // The IGitExt service isn't available when a TFS based solution is opened directly.
+            // It will become available when moving to a Git based solution (and cause a UIContext event to fire).
+            // NOTE: I tried using the RepositoryOpen context, but it didn't work consistently.
+            var context = factory.GetUIContext(new Guid(Guids.GitSccProviderId));
+            context.WhenActivated(() =>
+            {
+                log.Debug("WhenActivated");
+                JoinableTaskFactory.RunAsync(InitializeAsync).Task.Forget(log);
+            });
         }
 
         async Task InitializeAsync()
@@ -89,7 +94,10 @@ public void RefreshActiveRepositories()
                         gitService.GetHashCode(),
                         gitService.ActiveRepositories.Select(x => x.RepositoryPath));
 
-                    ActiveRepositories = gitService?.ActiveRepositories.Select(x => repositoryFactory.Create(x.RepositoryPath)).ToList();
+                    if (gitService != null)
+                    {
+                        ActiveRepositories = gitService.ActiveRepositories.Select(x => repositoryFactory.Create(x.RepositoryPath)).ToList();
+                    }
                 }
             }
             catch (Exception e)

test/GitHub.TeamFoundation.UnitTests/VSGitExtTests.cs

@@ -19,14 +19,15 @@ public class VSGitExtTests
 {
     public class TheConstructor : TestBaseClass
     {
-        [TestCase(true, 1)]
-        [TestCase(false, 0)]
-        public void GetServiceIGitExt_WhenRepositoryOpenIsActive(bool isActive, int expectCalls)
+        [TestCase(true, Guids.GitSccProviderId, 1)]
+        [TestCase(true, UICONTEXT.RepositoryOpen_string, 0, Description = "No longer using RepositoryOpen")]
+        [TestCase(false, Guids.GitSccProviderId, 0)]
+        public void GetServiceIGitExt_WhenGitSccProviderIsActive(bool isActive, string contextGuidString, int expectCalls)
         {
             var context = CreateVSUIContext(isActive);
             var sp = Substitute.For<IAsyncServiceProvider>();
 
-            var target = CreateVSGitExt(context, sp: sp);
+            var target = CreateVSGitExt(context, sp: sp, contextGuidString: contextGuidString);
 
             sp.Received(expectCalls).GetServiceAsync(typeof(IGitExt));
         }
@@ -210,15 +211,16 @@ static IReadOnlyList<IGitRepositoryInfo> CreateActiveRepositories(params string[
     }
 
     static VSGitExt CreateVSGitExt(IVSUIContext context = null, IGitExt gitExt = null, IAsyncServiceProvider sp = null,
-        ILocalRepositoryModelFactory repoFactory = null, JoinableTaskContext joinableTaskContext = null)
+        ILocalRepositoryModelFactory repoFactory = null, JoinableTaskContext joinableTaskContext = null, string contextGuidString = null)
     {
         context = context ?? CreateVSUIContext(true);
         gitExt = gitExt ?? CreateGitExt();
+        var contextGuid = new Guid(contextGuidString ?? Guids.GitSccProviderId);
         sp = sp ?? Substitute.For<IAsyncServiceProvider>();
         repoFactory = repoFactory ?? Substitute.For<ILocalRepositoryModelFactory>();
         joinableTaskContext = joinableTaskContext ?? new JoinableTaskContext();
         var factory = Substitute.For<IVSUIContextFactory>();
-        factory.GetUIContext(UICONTEXT.RepositoryOpen_guid).Returns(context);
+        factory.GetUIContext(contextGuid).Returns(context);
         sp.GetServiceAsync(typeof(IGitExt)).Returns(gitExt);
         var vsGitExt = new VSGitExt(sp, factory, repoFactory, joinableTaskContext);
         vsGitExt.JoinTillEmpty();

test/IntegrationTests/GitHubPaneIntegrationTests.cs

@@ -0,0 +1,28 @@
+using GitHub.VisualStudio;
+using Xunit;
+using EnvDTE;
+using Microsoft.VisualStudio.Shell;
+
+namespace IntegrationTests
+{
+    public class GitHubPaneIntegrationTests
+    {
+        const string GitHubPaneGuid = "{6B0FDC0A-F28E-47A0-8EED-CC296BEFF6D2}";
+
+        [VsFact(UIThread = true, Version = "2015-")]
+        public void ShowGitHubPane()
+        {
+            var dte = (DTE)ServiceProvider.GlobalProvider.GetService(typeof(DTE));
+            var window = dte.Windows.Item(GitHubPaneGuid);
+            window.Visible = false;
+            var command = dte.Commands.Item(Guids.guidGitHubCmdSet, PkgCmdIDList.showGitHubPaneCommand);
+
+            Assert.False(window.Visible);
+            Assert.True(command.IsAvailable);
+
+            dte.Commands.Raise(command.Guid, command.ID, null, null);
+
+            Assert.True(window.Visible);
+        }
+    }
+}