This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Fix a typo in the GitHub.UI.Reactive assembly title #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @mlaily! CI seems to have failed but it looks like this is due to the build failing on non-github account? @jcansdale you've submitted PRs recently from other accounts, did you see a similar problem? |
drguthals
reviewed
May 17, 2018
| @@ -3,7 +3,7 @@ | |||
| using System.Windows; | |||
| using System.Windows.Markup; | |||
|
|
|||
| [assembly: AssemblyTitle("GitHub.UI.Recative")] | |||
| [assembly: AssemblyTitle("GitHub.UI.Reactive")] | |||
There was a problem hiding this comment.
Thanks for catching this!
grokys
approved these changes
May 22, 2018
|
Merged, thanks @mlaily for spotting this! (and causing us to fix our CI for external contributors in the process ;) ) |
|
You are welcome :p |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.