Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allows a username other than git when using an ssh key #7618

Merged
merged 2 commits into from
Mar 14, 2025

Conversation

Hedroed
Copy link
Contributor

@Hedroed Hedroed commented Mar 13, 2025

🧢 Changes

Get username from ssh git URI and use it in the libgit2 API.

☕️ Reasoning

I have a use case where the ssh git URI use gitea as username and i need to use an ssh key.

Copy link

vercel bot commented Mar 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2025 0:27am

Copy link

vercel bot commented Mar 13, 2025

@Hedroed is attempting to deploy a commit to the GitButler Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for contributing, it's much appreciated.

I also can't think of a reason to ignore the username provide in the URL when using SSH URLs and the git2 backend.

@krlvi what do you think?

@krlvi
Copy link
Member

krlvi commented Mar 13, 2025

Thanks a lot for contributing, it's much appreciated.

I also can't think of a reason to ignore the username provide in the URL when using SSH URLs and the git2 backend.

@krlvi what do you think?

Yeah seems reasonable. I plan to make a release now before this change, and then merge this, so that we can test this in the nightly for a day or so

@krlvi krlvi merged commit 4bce3d8 into gitbutlerapp:master Mar 14, 2025
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants