Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(link-check): mark outdated link check comments as such #1970

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

dscho
Copy link
Member

@dscho dscho commented Mar 6, 2025

Changes

  • Let the link checker, which adds new comments to existing link check issues if there still is an open one, hide its own now-outdated comments from previous runs.

Context

In particular with long-running issues where links are broken for weeks (and over the course of dozens of git-scm.com deployments), while it is nice that the link checker adds the most recent "verdict", the previous ones are no longer that interesting. Let's hide them.

This is the case for example in #1962.

I verified that this patch works over in my fork where this workflow run added this issue comment and marked all previous ones as outdated, as desired.

In particular with long-running issues where links are broken for weeks
(and over the course of dozens of git-scm.com deployments), while it is
nice that the link checker adds the most recent "verdict", the previous
ones are no longer _that_ interesting. Let's hide them.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho self-assigned this Mar 6, 2025
@dscho dscho merged commit 00fc134 into git:gh-pages Mar 10, 2025
1 check passed
@dscho dscho deleted the mark-outdated-link-checker-comments branch March 10, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant