Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files/site.js: forward key events to embedded examples #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mearaj
Copy link

@mearaj mearaj commented Jul 31, 2023

Fixes: https://todo.sr.ht/~eliasnaur/gio/415
Signed-off-by: Mearaj Bhagad [email protected]

For some reason most, probably iframes (may be event focus), the gio window inside iframe doesn't receives key events. In this commit, a global key event listener is added and it passes down key events to gio's window embedded inside iframes.

@mearaj mearaj changed the title "files/site.js: forward key events to embedded examples" files/site.js: forward key events to embedded examples Jul 31, 2023
@eliasnaur
Copy link
Contributor

CC @inkeliz @egonelbre .

Note that you don't have to create a new pull request. You can git commit --amend, git rebase -i and so on and then git push --force-with-lease to amend your PR.

I only have style nits:

  • Don't include quotation marks in the commit title, and leave a newline after it.
  • The Fixes: and Signed-off-by: belong last in the commit message.

So:

files/site.js: forward key events to embedded examples

For some reason most, probably iframes (may be event focus),
the gio window inside iframes doesn't receives key events.
In this commit, a global key event listener is added and it passes
down key events to gio's window embedded inside iframes.

Fixes: https://todo.sr.ht/~eliasnaur/gio/415
Signed-off-by: Mearaj Bhagad <[email protected]>

For some reason most, probably iframes (may be event focus),
the gio window inside iframe doesn't receives key events.
In this commit, a global key event listener is added and it passes
down key events to gio's window embedded inside iframes.

Fixes: https://todo.sr.ht/~eliasnaur/gio/415
Signed-off-by: Mearaj Bhagad <[email protected]>
@mearaj
Copy link
Author

mearaj commented Aug 1, 2023

Hi, I am really sorry for unnecessarily creating another PR. After commits squash, I wasn't able to PR for this branch, so created another PR. This time I did it again following your instructions. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants