Package to open browser url from gio app #17
Conversation
|
@g45t345rt It’s a bummer that this repo does not have example sub folders . The convention is to have the examples in the gio-examples repo @whereswaldon would it be a terrible idea to allow examples to go into this actual repo ? |
I keep them separate out of a desire to keep the dependency tree for |
|
You can take https://github.com/inkeliz/giohyperlink as example. In the case of iOS: https://github.com/inkeliz/giohyperlink/blob/main/giohyperlink_ios.go. |
|
@inkeliz Damn, I didn't know this existed :O Why is this not part of gio-x package? |
We've talked about merging it, but I don't remember why we never did. |
|
Unrelated to this topic, I started working on camera access. You can find the code in this branch: @inkeliz, pls tell me you haven't done this already :S I've searched your repos and could'nt find anything. |
I didn't. Most of packages are available under https://github.com/gioui-plugins/gio-plugins. Here you can see what I have consider to implement (https://github.com/orgs/gioui-plugins/projects/1). I had consider to implement Camera, Microphone, Geolocation/GPS in the past. However, that is quite hard to do it right without a proper use-case. I'm not sure how the camera is suppose to work (if that opens the camera app; or if that "embeds" the frame inside Gio). If is the second method (which receives an image-per-frame): I think it might be a good ideia to expose some "ring-buffer". Instead of allocate bytes each frame, you can re-use the same byte-array (kind of triple-buffer). That also prevents copying from Java to Go again, which may improve performance on low-low-low-end devices. |
There was a problem hiding this comment.
This is overwhelmingly similar to giohyperlink, to the point that I wonder whether @inkeliz would be willing to combine your efforts and get the result landed in gioui.org/x. In particular, you've found a way to implement support for Android that does not require adding an extra handler to the window event loop, which is a nice simplification.
I've been diffing this code against giohyperlink as I reviewed it to see the various strategies for implementing things, and I think something along the lines of giohyperlink's scheme validation is probably necessary. Opening URLs can do practically anything if they might trigger a custom application-defined URL scheme like zoom:// or slack://. Frequently applications will need to open content provided by users, and they need to guard against malicious attempts to manipulate URL handling.
As such, I think we really need the union of this PR and giohyperlink to provide the safest, simplest path forward. In particular, I think the goal should be:
- no event loop modifications needed for basic use (it seems like it may only be necessary for some fallback logic in
js) - use parsed, structured URLs instead of strings, and offer control over which URL schemes are able to be opened
- use the simplest integration option available on each platform
| func OpenUrl(url string) error { | ||
| js.Global().Call("open", url, "_blank", "") | ||
| return nil | ||
| } |
There was a problem hiding this comment.
How widely did you test this across browser platforms? I'm curious whether @inkeliz's sophisticated hacks are needed here.
There was a problem hiding this comment.
In Safari, the open function must be invoked inside onClick event. However, Gio gets and releases this event.
If open is called without direct user interaction, outside of onClick, it may not always work. It's inconsistent, so sometimes it works, but often it doesn't.
The "hack" requires the user to click anywhere in the page to open, it's not perfect, but works as fallback.
| ) | ||
|
|
||
| func OpenUrl(url string) error { | ||
| cmd := exec.Command("cmd", "/c", "start", url) |
There was a problem hiding this comment.
Given that we can avoid spawning a cmd instance for this, I think I'd prefer using that more direct approach.
Follow up on this pull request gioui/gio#119
Simple usage
Cross-platform implemented
Android - Intent object
Windows - exec command "cmd /c start"
Unix - exec command "xdg-open"
Macos - exec command "open"
IOS - UIApplication openURL
JS - window.open
P.S I'm coding blind for IOS implementation. I don't have a mac + I have no idea how to test/build either.