Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add path to ndk on termux on arm64 for android 9+ #7

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MatejMagat305
Copy link

it available to build app on android app - termux

again

it available to build app on android app - termux
@MatejMagat305
Copy link
Author

if it not working you can close and write this own

Copy link
Contributor

@eliasnaur eliasnaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about Termux on Android on x86_64 (emulator) or other GOARCHs? Your change only handles GOARCH arm64.

Also, I suggest changing the commit message to:

gogio: add support for Termux

Termux reports "android" for GOOS, but should be treated the same as "linux".

gogio/androidbuild.go Outdated Show resolved Hide resolved
@MatejMagat305 MatejMagat305 changed the title add path to ndk on termux add path to ndk on termux on arm64 for android 9+ May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants