Jonoabroad master #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ovider.makeApiRequest.
For example: GithubProvider.makeApiRequest("user", "access_token" -> accessToken)
I re-worked quite a few lines to make it easier (for me) to debug and track down this issue, but the real change is just to ensure the User-Agent is sent.
I also added an Accept header to set the API version to be v3, which GitHub are encouraging.
Gitub API requires User-Agent
…oabroad-master Conflicts: src/main/scala/omniauth/lib/GithubProvider.scala
…oabroad-master Conflicts: src/main/scala/omniauth/lib/GithubProvider.scala
|
@jonoabroad Just a quick bump to see if you had a chance to look this over while I'm cleaning up PRs. |
|
Sorry I have not. We have been super busy. On 23 April 2014 12:46, Joe Barnes [email protected] wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jonoabroad Ran into conflicts with your PR #33 could you verify if that this branch is working correctly. Once it is I will get your changes into master. Thanks.