Bugfix - Fixes in CSS generation - "sketch_css" #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fn size_to_string(value) { | ||
| fn size_to_string(size: String) -> String { | ||
| case size { | ||
| "percent" -> "%" |
There was a problem hiding this comment.
I haven't found a better way to do that, since the name of the size function is "percent" and the value for the size variable comes from the AST
ghivert
reviewed
Oct 28, 2024
Comment on lines
+478
to
+483
| fn size_to_string(size: String) -> String { | ||
| case size { | ||
| "percent" -> "%" | ||
| _ -> size | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe you could do something like this, but your version is fine. 🙂
Suggested change
| fn size_to_string(size: String) -> String { | |
| case size { | |
| "percent" -> "%" | |
| _ -> size | |
| } | |
| } | |
| fn size_to_string(size: String) -> String { | |
| use <- bool.guard(when: size == "percent", return: "%") | |
| size | |
| } |
|
Thanks for your PR! I see you're still pushing some fixes, do you think you have additional fixes to do, or is it OK as is? |
|
I think it's OK, those are the only issues I've stumbled upon. The rest of the library is working great! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 3 issues with CSS generation using "sketch_css":
z_index(100)was generated with the property namez_indexinstead ofz-index.opacity(1.0)generated asopacity: ;.width(percent(100))being generated aswidth: 100percentinstead ofwidth: 100%.