Merge pull request #26 from ghivert/fix/fix-target-in-erlang

Fix correct signature for `cache` on Erlang target
ghivert · Sep 17, 2024 · c4814eb · c4814eb
2 parents 34b2416 + 1707d31
commit c4814eb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/sketch/src/sketch/error.gleam b/sketch/src/sketch/error.gleam
@@ -1,5 +1,9 @@
 //// Defines standard error returned by sketch.
 
+import gleam/otp/actor
+
+/// NotABrowser is unused nowadays. It will be removed in v4.
 pub type SketchError {
   NotABrowser
+  OtpError(actor.StartError)
 }
diff --git a/sketch/src/sketch/internals/cache/setup.gleam b/sketch/src/sketch/internals/cache/setup.gleam
@@ -6,6 +6,7 @@ import gleam/list
 import gleam/otp/actor
 import gleam/pair
 import gleam/result
+import sketch/error.{type SketchError}
 import sketch/internals/cache/state
 import sketch/internals/style
 
@@ -21,9 +22,11 @@ pub fn ephemeral() {
 }
 
 @target(erlang)
-pub fn persistent() -> Result(Cache, Nil) {
-  let assert Ok(subject) = actor.start(style.persistent(), state.loop)
-  Ok(PersistentCache(subject))
+pub fn persistent() -> Result(Cache, SketchError) {
+  let subject = actor.start(style.persistent(), state.loop)
+  subject
+  |> result.map(PersistentCache)
+  |> result.map_error(error.OtpError)
 }
 
 @target(erlang)