Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Row Detail should also work with fixed grid height or w/o autoHeight #1540

Merged
merged 4 commits into from
Mar 19, 2025

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Mar 11, 2025

  • defining a fixed grid height and/or disabling resizer.autoHeight should expect the Row Detail to still work properly (it wasn't before this PR)
    • the resizer.autoHeight had a side effect of calling row invalidate after the resize and this side effect was in fact hiding the UI problems described above, which meant that in a few occasions, the Row Details weren't invalidated/redrawn properly
  • also rewrite the pre/post templates to use native HTML code instead of HTML string, which is better for perf and also more secure without requiring any sanitization

Copy link

stackblitz bot commented Mar 11, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3fbf4ba) to head (7b28641).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1540   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines         1625      1621    -4     
  Branches       468       464    -4     
=========================================
- Hits          1625      1621    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ghiscoding ghiscoding added the requires Universal change/release code change must first be implement in Slickgrid-Universal label Mar 11, 2025
@ghiscoding ghiscoding changed the title fix: Row Detail should also work with fixed grid height or no autoHeight fix: Row Detail should also work with fixed grid height or w/o autoHeight Mar 12, 2025
@ghiscoding ghiscoding merged commit 2f249fc into master Mar 19, 2025
4 checks passed
@ghiscoding ghiscoding deleted the bugfix/row-detail-auto-height branch March 19, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires Universal change/release code change must first be implement in Slickgrid-Universal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant